On Thursday 03 December 2009 11:30:50 pm Jeff Garzik wrote: > On 12/03/2009 05:23 PM, Bartlomiej Zolnierkiewicz wrote: > > On Thursday 03 December 2009 11:10:51 pm Jeff Garzik wrote: > >> Is it good kernel practice to intermingle cosmetic changes with > >> functional ones, in the same code lines? Also, no. > > > > I prefer using common sense over black-and-white rules. > > > > If patch is a _really_ tiny one (< 20 LOC changed) it sometimes makes > > sense to save the time on handling separate patches. > > This is open source -- you have to consider the time saved by reviewers too. Like I said previously this is best done on per-case basis and because it is open source eventually people will come up with an alternative patch if they find the current one too bothersome to review, merge etc. > But I doubt you have saved time on all your motivated commit searches, so... Well, just two basic searches limited to one contributor and one directory.. -- Bartlomiej Zolnierkiewicz -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
