On 12/03/2009 05:10 PM, Jeff Garzik wrote:
Did the patch contain -cosmetic- changes intermingled with code changes, in the same code lines? No. Is it good kernel practice to intermingle cosmetic changes with functional ones, in the same code lines? Also, no.
In fact, I recall one case where a certain developer on this list used cosmetic code changes (Lindent, IIRC) to hide functional, security-related code changes.
Mixing cosmetic and function changes is simply bad engineering practice, _especially_ when they occur in the same lines of code.
Jeff -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
