Re: [PATCH #upstream, v3] ahci: Implement SATA AHCI FIS-based switching support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 09/08/2009 05:28 AM, Shane Huang wrote:
Implement SATA AHCI FIS-based switching support.

Tested on AMD internal reference board.

Signed-off-by: Shane Huang<shane.huang@xxxxxxx>
Cc: Tejun Heo<tj@xxxxxxxxxx>
---
Changes from the last version(v2):
* Move fbs_need_dec from struct ahci_port_priv to ahci_error_intr() as
   a local variable.
* Add BUG_ON(!pp->fbs_enabled) for ahci_fbs_dec_intr().
* Refine the retry loop in ahci_fbs_dec_intr().
* Refine the code to determine failed active link with ap->pmp_link in
   ahci_error_intr().
* WARN_ON() in ahci_port_intr() can storm the machine with consecutive
   stack dumps, replace it with WARN_ON_ONCE().
* Refine ahci_enable_fbs()/ahci_disable_fbs(), and discard the message
   for controllers which do not support FBS.
* Add a warning message in ahci_port_start() for those weird controllers
   which support CAP.FBSS but do not support PxCMD.FBSCP.
* Several small corrections for better coding style.

  drivers/ata/ahci.c |  225 +++++++++++++++++++++++++++++++++++++++++++++++-----
  1 files changed, 206 insertions(+), 19 deletions(-)

OK, I'm ready to get back to this... Would you please resubmit this patch, rediff'd for the current upstream kernel?

I will queue it for kernel 2.6.34, because it needs plenty of testing -- both for FBS-enabled AHCI, and to be sure we don't break non-FBS AHCI.

	Jeff




--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Filesystems]     [Linux SCSI]     [Linux RAID]     [Git]     [Kernel Newbies]     [Linux Newbie]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Samba]     [Device Mapper]

  Powered by Linux