On 12/01/2009 02:30 PM, Benjamin Herrenschmidt wrote: >> You didn't schedule any EH actions, right? > > I did the usual ehi_hotplug + freeze Hmmm.... then I have no idea what happened there. :-( >> libata-acpi.c does that. Setting ATA_DFLAG_DETACH device flag and >> scheduling EH will do that. Please take a look at >> ata_acpi_detach_device() but you must be *sure* that your hot unplug >> notification is completely reliable. > > Well, it seems to be reliable that way for unplugs. I even debounce it > both ways but I'm actually considering removing the debounce on unplug. > > I'll let you know how it goes with a custom prereset() that returns > -ENODEV. How would that differ from ATA_DFLAG_DETACH ? In effect, they would be the same but if the hotplug notification can be made reliable, I think using DFLAG_DETACH would be better as there's already other users doing that (user requested detach and ACPI dock removal). Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
