Re: [PATCH 4/5] libata: Report zeroed read after Trim and max discard size

[Mark Lord <kernel@xxxxxxxxxxxx>]

Martin K. Petersen wrote:
..
> If a storage device supports Trim and the DRAT and RZAT bits are set,
> report TPRZ=1 in Read Capacity(16).
..
> +static inline int ata_id_has_zero_after_trim(const u16 *id)
> +{
> +	/* DSM supported, deterministic read, and read zero after trim set */
> +	if (ata_id_has_trim(id) && id[ATA_ID_ADDITIONAL_SUPP] & 0x4020)
> +		return 1;
..

Is that correct, or should it be this:

       if (ata_id_has_trim(id) && (id[ATA_ID_ADDITIONAL_SUPP] & 0x4020) == 0x4020)

??
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html