On Wednesday 25 November 2009 08:34:19 pm Alan Cox wrote: > On Wed, 25 Nov 2009 19:10:06 +0100 > Bartlomiej Zolnierkiewicz <bzolnier@xxxxxxxxx> wrote: > > > On Wednesday 25 November 2009 07:06:48 pm Alan Cox wrote: > > > > Do you really find such tidy patch hard to review? > > > > > > When doing it at speed - yes. > > > > Do you review everybody else patches 'at speed' or only mine? > > All of them when I've got a lot of stuff to do. Owing to a lack of time > machine and 500 hour days it's neccessary. > > Also btw take it is a compliment - there are some people's patches I > always review in detail and it isn't the patches you expect to be *right* > that you spend the time on... Well, you don't really have to review every single patch touching areas that you're just interested in (and if you're maintaining those drivers please document it in MAINTAINERS file, thanks). The problem is that in case you're not entirely correct, which is much more likely when doing things 'at speed', you're will be wasting time for everybody (not that I really care that much about others' time but I do care about mine). -- Bartlomiej Zolnierkiewicz -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html