>>>>> "Christoph" == Christoph Hellwig <hch@xxxxxxxxxxxxx> writes: Christoph> On Fri, Nov 20, 2009 at 09:45:24PM -0500, Martin K. Petersen wrote: >> ata_set_lba_range_entries confused indexes into a u64 buffer with >> byte offsets. Fix this up and document the return value. >> >> Update the libata write same translation to reflect this. Christoph> Once we fix up this beast we should also change the current Christoph> max argument to encode the buffer size, not the maximum Christoph> number of entries which is a rather confusing interface. What threw me off yesterday was that `max' starts out being a cap on the number of 8-byte entries in the buffer. And then towards the end it suddenly turns into a number-of-bytes entity as a result of the ALIGN macro. I agree that we should fix this up to be consistent. I'll do that. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
