On Thursday 19 November 2009 19:21:32 Alan Cox wrote: > > Fixed where? I posted the patch as soon as I noticed the problem. > > Its not posted because unlike you I don't post patches as soon as I > notice them. I test them first. Which is why for example I discovered the > bug in the drivers/ide one. Did you check the vendor driver and then > stick 40 and 80 wire cables on the system to check the bits on a 3x2N ? > No I didn't think so. You see if you had you'd have discovered something I did check the vendor driver but I don't have 3x2N to test it so posting patch ASAP to make it possible for other people to verify it was the best course of action and completely justified. Don't you agree? > else. You'd have discovered another bug in the old IDE one. The driver You mean 'another' like yours _three_ year old 'one'? :) > code for these chips isn't reliable and doesn't work at all in some cases. > > > Told me about it? > > Yes - or do you only write replies not read them ? Well, yours have low SNR and I value my time.. > NAK - the patch is inadequate. The procedure in the vendor driver does Patch is completely adequate in what it tries to achieve (fixing three year old problem with testing the bit for the wrong port) and you could have made an incremental fix for 'a second issue' easily. However I'm not into NIH so your patch is also fine and a more complete one. > pata_hpt3x2n: Fix cable detection > > The version inherited from drivers/ide doesn't work on the newer chipsets > at least not reliably. The vendors own driver uses a different process and > that one appears to produce plausible numbers. Well, maybe except how you decided to 'skip' in the patch description the part about how you have managed to introduce a regression three years ago into already unreliable cable detection taken from hpt366.. ;) -- Bartlomiej Zolnierkiewicz -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
