On Thursday 19 November 2009 15:50:25 Bartlomiej Zolnierkiewicz wrote: > On Thursday 19 November 2009 15:33:51 Alan Cox wrote: > > On Thu, 19 Nov 2009 15:17:14 +0100 > > Bartlomiej Zolnierkiewicz <bzolnier@xxxxxxxxx> wrote: > > > > > On Thursday 19 November 2009 14:16:36 Alan Cox wrote: > > > > > Only pata_hpt37x has broken cable detection while pata_hpt3x2n is > > > > > okay. ;) > > > > > > > > I think you have that backwards according to the vendor drivers. 3x2n > > > > looks like it needs adjusting. > > > > > > lol, just fix the damn pata_hpt37x driver _lacking_ ->cable_detect method.. > > > > It doesn't need one. It still sets the cable type in the pre reset > > function as the older drivers that haven't converted to a cable_detect > > method do. > > If you know about other drivers still using ->pre_reset for cable detection > please let us know because they need fixing ASAP. No need for it any longer. I'll send patches later. -- Bartlomiej Zolnierkiewicz -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html