Alan Cox wrote:
BTW we can immediately reclaim 300 LOC by simply merging drivers back..
LoC - lines of comments ? (at least half of them).
Been testing a bit before fixing up the pata_hpt drivers. Resume from S2R doesn't work with drivers/ide/hpt366.c. So it may have code for resume but it doesn't actually work for all the chips.
Reason is fairly obvious - the PCI speed detection logic is broken except for the case of a PC boot where the ROM BIOS for the HPT3xx is run. That
Point out the breakage please. The driver has been developed and tested on non-x86 machine with 66 MHz PCI.
doesn't occur on a resume from RAM so a 66MHz clocked motherboard device comes back with the speed guessed wrongly.
WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
