On Tuesday 17 November 2009 15:51:17 Alan Cox wrote: > Bartlomiej pointed out that while this got fixed in the old driver whoever > did it didn't port it across. Please add ',' before 'whoever' and change 'the old driver' to 'sis5513' so it is at least passable as 'information manipulation' on what I really said instead of just being a 'straight lie'.. Thanks! > +/** > + * mwdma_clip_to_pio - clip MWDMA mode > + * @adev: device > + * > + * As the SiS shared MWDMA and PIO timings we must program the equivalent > + * PIO timing for the MWDMA mode but we must not program one higher than > + * the permitted PIO timing of the device. > + */ > + > +static int mwdma_clip_to_pio(struct ata_device *adev) > +{ > + const int mwdma_to_pio[3] = { > + XFER_PIO_0, XFER_PIO_3, XFER_PIO_4 > + }; > + return min(mwdma_to_pio[adev->dma_mode - XFER_MW_DMA_0], > + adev->pio_mode - XFER_PIO_0); > +} This wants to be in the generic libata code. -- Bartlomiej Zolnierkiewicz -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html