> > Eg. sata_mv, sata_sil, .. won't work as-is with this command. > > I can certainly add a blacklist, do you have a complete list of > controllers that should be blacklisted. Also is there a good reason > why they are blacklisted or ist just controller bugs? I'm not convinced that is the right way to handle it. If we start doing that we'll have this massive unmanagable set of magic flags and twiddles for every possible host specific corner case. Far better to keep the issue of the command as Christoph has done and block the command issue in the afflicted devices qc_issue so that you get an error back. That keeps the mess in the right places. Christoph - the problem with some overly bright and IMHO misdesigned controllers is that they've got magic tables for command lengths in them to drive their ATA state machines. Those controllers tend to need special handlers when new commands come along to explain to them in simple terms what sort of command it is and wipe their backside afterwards. That belongs in the crappy hardware drivers not in the core code. Alan -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
