On Mon, 16 Nov 2009 23:59:39 +0900 Tejun Heo <tj@xxxxxxxxxx> wrote: > Arjan van de Ven wrote: > > is there a hardware way to ask for the link status via a link level > > thing? I thought the sata_scr_read() was by definition a host thing > > sata_scr_read() will do the right thing given the link parameter > although it needs to be called from EH context for PMP links. For > now, just making the functions take @link param and passing it around > should do. > I'm sorry it just does not make sense to me anymore. if this moves to be a link level thing, then the statistics also need to be kept link level, and thus exported link level, and I don't think that exists. if that ever comes into existence it's easy to change the whole thing at that time (and I'll then change PowerTOP to match). But doing some half "oh and if you call it on THIS kind of object it'll explode" does not sound sensible. I think I'm waaaay out of my league in terms of understanding the libata structure in the things you are suggesting to be honest, and I do not feel I understand enough of the subtleties in this area. -- Arjan van de Ven Intel Open Source Technology Centre For development, discussion and tips for power savings, visit http://www.lesswatts.org -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
