Hi Tejun,
2009/10/21 Tejun Heo <tj@xxxxxxxxxx>:
> Yoichi Yuasa wrote:
>> Signed-off-by: Yoichi Yuasa <yuasa@xxxxxxxxxxxxxx>
>>
>> ---
>> drivers/ata/sata_sil.c | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/ata/sata_sil.c b/drivers/ata/sata_sil.c
>> index 3cb69d5..d7fff6b 100644
>> --- a/drivers/ata/sata_sil.c
>> +++ b/drivers/ata/sata_sil.c
>> @@ -439,7 +439,7 @@ static void sil_host_intr(struct ata_port *ap, u32 bmdma2)
>> u8 status;
>>
>> if (unlikely(bmdma2 & SIL_DMA_SATA_IRQ)) {
>> - u32 serror;
>> + u32 serror = 0;
>
> The first usage of that is
>
> sil_scr_read(&ap->link, SCR_ERROR, &serror);
>
> which sets the value. So, I don't think the patch is necessary. If
> it triggers a compile warning, putting uninitialized_var() macro will
> be more appropriate.
If sil_scr_read() is error, 'serror' is not initialized.
After that, the wrong bits add to 'ap->link.eh_info.serror' when
'serror & SERR_PHYRDT_CHG' is true.
Yoichi
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
