On Tue, 06 Oct 2009 16:07:51 +0100 Alan Cox <alan@xxxxxxxxxxxxxxx> wrote: > The SC1200 needs a NULL terminator or it may cause a crash on boot. > > Bug #14227 > > Also correct a bogus comment as the driver had serializing added so can run > dual port. > > Signed-off-by: Alan Cox <alan@xxxxxxxxxxxxxxx> > --- > > drivers/ata/pata_sc1200.c | 3 +-- > 1 files changed, 1 insertions(+), 2 deletions(-) > > > diff --git a/drivers/ata/pata_sc1200.c b/drivers/ata/pata_sc1200.c > index f49814d..3bbed83 100644 > --- a/drivers/ata/pata_sc1200.c > +++ b/drivers/ata/pata_sc1200.c > @@ -235,8 +235,7 @@ static int sc1200_init_one(struct pci_dev *dev, const struct pci_device_id *id) > .udma_mask = ATA_UDMA2, > .port_ops = &sc1200_port_ops > }; > - /* Can't enable port 2 yet, see top comments */ > - const struct ata_port_info *ppi[] = { &info, }; > + const struct ata_port_info *ppi[] = { &info, NULL }; > > return ata_pci_sff_init_one(dev, ppi, &sc1200_sht, NULL); > } This patch applies to 2.6.31 and 2.6.30 (at least). How far back should it be ported? There was no Cc:stable in the changelog. There was no Cc:stable in the mail headers. Nor cc:linux-ide. Adding a Reported-by: is nice. Please use the form Addresses http://bugzilla.kernel.org/show_bug.cgi?id=14227 when mentioning bugzilla reports within changelogs. To provide a nice greppable pattern for those people who might close off old reports for us. -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html