Jeff Garzik wrote: > On 10/06/2009 04:08 AM, Tejun Heo wrote: >> While trying to work around spurious detection retries for >> non-existent devices on slave links, commit >> 816ab89782ac139a8b65147cca990822bb7e8675 incorrectly added link >> offline check logic before ata_eh_thaw() was called. This means that >> if an occupied link goes down briefly at the time that offline check >> was performed, device class will be cleared to ATA_DEV_NONE and libata >> wouldn't retry thus failing detection of the device. >> >> The offline check should be done after the port is thawed together >> with online check so that such link glitches can be detected by the >> interrupt handler and handled properly. >> >> Signed-off-by: Tejun Heo<tj@xxxxxxxxxx> >> Reported-by: Tim Blechmann<tim@xxxxxxxxxx> >> Cc: stable@xxxxxxxxxx >> -- >> drivers/ata/libata-eh.c | 50 >> ++++++++++++++++++++++++++++++------------------ >> 1 file changed, 32 insertions(+), 18 deletions(-) > > applied. BTW, note your separator lost a dash... it should be three > dashes (---). Oops, sorry about that. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
