On 09/15/2009 09:07 AM, Mikael Pettersson wrote:
1st generation Promise SATA chips are prone to generating spurious hotplug events which can disrupt normal operation. This has been observed on 20376 and 20378 chips. This patch thus disables hotplug support on 1st gen chips while leaving it enabled for 2nd gen chips. The pdc_sata_hotplug_offset() function becomes redundant so it is removed. Tested on 1st gen 20376 and 20378 mainboard chips and on a 2nd gen SATA300 PCI card. Signed-off-by: Mikael Pettersson<mikpe@xxxxxxxx> Tested-by: Kurt Roeckx<kurt@xxxxxxxxx> --- Kurt: you tested this so I added your Tested-by, I hope that's Ok? Jeff: this is a safe patch that I think should go to -stable soonish drivers/ata/sata_promise.c | 34 +++++++++++++++++----------------- 1 file changed, 17 insertions(+), 17 deletions(-)
Applied, though I would rather see hotplug be made a runtime decision: default off, but with an option to enable
Jeff -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
