Commit 54c38444fad6a99b4b19512f8f0055d69115e69e

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Jeff,

Commit 54c38444fad6a99b4b19512f8f0055d69115e69e triggers
WARN_ON_ONCE(ap->pflags & ATA_PFLAG_FROZEN); in ata_qc_complete().
>From the commit history, it seems the change was to add DMA engine
disable to sil_freeze(), right?  I can't see why changing the orders
would matter there.  ata_port_abort() just changes the internal state
of libata and doesn't affect low level driver or the hardware.
Whether doing it before or after __ata_port_freeze() shouldn't make
any different to sata_sil's freeze callback.  Am I missing something?

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Filesystems]     [Linux SCSI]     [Linux RAID]     [Git]     [Kernel Newbies]     [Linux Newbie]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Samba]     [Device Mapper]

  Powered by Linux