Jeff Garzik wrote: > On 09/03/2009 03:08 AM, Tejun Heo wrote: >> ata_scsi_pass_thru() was checking for input sanity and disallowed >> commands while initializaing qc from scmd. TPM filtering was added >> right after protocol check at which point tf wasn't initialized >> properly. This means that TPM filtering has never really worked. >> >> This patch fixes the bug by reorganizing ata_scsi_pass_thru() such >> that qc is fully initialized before checking for invalid conditions >> which is way less error prone. >> >> Discovered while Thilo-Alexander Ginkel was trying debug patches for >> bko#13416. >> >> Signed-off-by: Tejun Heo<tj@xxxxxxxxxx> >> Cc: Thilo-Alexander Ginkel<thilo@xxxxxxxxxx> > > If it has never really worked, I would prefer #upstream at this point... Ummm... Yeap, agreed. Far too deep into -rc cycle. Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
