Hello, Gwendal. Gwendal Grignou wrote: > You have a point, but setting the flag LOCKED when an error happen > will mean that a braindead device [which always trigger > ata_id_locked()] will work until an internal disk error happens; that > will make debugging difficult. Yeah, right, unrelated error can set the LOCKED bit. Maybe we can devise something intelligent there. A simple state machine to detect those conditions? > Instead, I am working on adding the provision for a blacklist to allow > bad devices to bypass the test. Blacklist wouldn't be too bad too but I really think we shouldn't be believing the identify data at the face value. What if the device sets the bit after security_lock but fails to fail commands which wouldn't be all that surprising given the general quality of ATA devices which has been diving rapidly with all those new vendors jumping onto the SDD wagon? So, I think it should still be something recognized and verified by EH before applying. Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
