On Sat, Aug 22, 2009 at 10:10 AM, Jeff Garzik<jeff@xxxxxxxxxx> wrote: > On 08/22/2009 11:28 AM, Mark Lord wrote: >> >> Mmm.. I wonder if something like this patch might also be applicable >> to the sata_sil.c driver too? > > > Not AFAICT. The 3112 has a Command Protocol Table inside the chip. Each > command reads the ATA command protocol from that table. The table is > programmable (see section 10.3 of [1]), but not on a per-command basis. The > per-command PRD format is pretty much legacy IDE[2], and nothing like the > modern FIS-based controllers. I think it should be possible to send trim commands through the 311x, but the protocol override is done differently, you'd have to send a VS Set Command Protocol command in order to set the protocol code for that command/feature combination to the correct DMA protcol code. It's not quite as general a solution as with the 3124/3132 controllers (you have to tell it specifically about each command it doesn't know about). Also the set protocols get erased on COMINIT/COMRESET so you'd have to redo the override post-reset. -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
