ATA_QCFLAG_RETRY is already set [by _autopsy()], ata_eh_qc_retry() was already called, but given retries is 0, we can not reduce it. However, I will submit a better patch, in ata_eh_qc_retry(). Gwendal. On Fri, Aug 7, 2009 at 1:34 AM, Tejun Heo<tj@xxxxxxxxxx> wrote: > Gwendal Grignou wrote: >> The explanation did not go through git-send-email: >> >> Without this fix, ATA passthrough commands are not resend to the >> drive, and no error is >> signalled to the caller because: >> - allowed retry count is 1 >> - ata_eh_qc_complete fill the sense data, so result is valid My mistake: __ata_eh_qc_complete() instead of ata_eh_qc_complete(). >> - sense data is filled with untouched ATA registers. > > Would setting ATA_QCFLAG_RETRY achieve the same result? > > Thanks. > > -- > tejun > -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
