RE: [PATCH] kill @force_restart and refine CLO for ahci_kick_engine()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Tejun, 

> -----Original Message-----
> From: Tejun Heo [mailto:tj@xxxxxxxxxx] 
> 
> Please make the subject look like,
> 
>  [PATCH #upstream] ahci: kill @force_restart....
> 
> Shane Huang wrote:
> > This patch refines ahci_kick_engine() after discussion with 
> Tejun about
> > FBS(FIS-based switching) support preparation:
> > a. Kill @force_restart and always kick the engine. The only 
> case where
> >    @force_restart is zero is when it's called from 
> ahci_p5wdh_hardreset()
> >    Actually at that point, BSY is pretty much guaranteed to be set.
> > b. If PMP is attached, ignore busy and always do CLO. (AHCI-1.3 9.2)
> > 
> > Signed-off-by: Shane Huang <shane.huang@xxxxxxx>
> > Cc: Tejun Heo <tj@xxxxxxxxxx>
> 
> And put the followings here
> ---
> DIFFSTAT OUTPUT
> 
> > 
> > diff -ruN a/drivers/ata/ahci.c b/drivers/ata/ahci.c
> > --- a/drivers/ata/ahci.c	2009-07-29 14:38:39.000000000 +0800
> > +++ b/drivers/ata/ahci.c	2009-08-06 17:36:59.000000000 +0800
> > @@ -1578,7 +1578,7 @@
> 
> and use -p when generating diffs.  It's usually best to generate diff
> from a git tree.
> 
> Other than the above peripheral issues,
> 
> Acked-by: Tejun Heo <tj@xxxxxxxxxx>

 
OK, I will follow your suggestions next time when I submit patches,
for this patch, I will not re-submit.


Thanks
Shane

--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Filesystems]     [Linux SCSI]     [Linux RAID]     [Git]     [Kernel Newbies]     [Linux Newbie]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Samba]     [Device Mapper]

  Powered by Linux