On Thu, Aug 06, 2009 at 08:54:31AM +0200, Håkon Løvdal wrote: > Maybe I am missing something, but wouldn't it be more natural to write this as > > if (sata_pmp_attached(ap)) > adr = SATA_ADR(ap->port_no, dev->link->pmp); > else > adr = SATA_ADR(ap->port_no, NO_PORT_MULT); Heh, yes. That would also work. -- Matthew Garrett | mjg59@xxxxxxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html