Jeff Garzik wrote:
>> diff --git a/drivers/ata/sata_sil24.c b/drivers/ata/sata_sil24.c
>> index 77aa8d7..e6946fc 100644
>> --- a/drivers/ata/sata_sil24.c
>> +++ b/drivers/ata/sata_sil24.c
>> @@ -846,6 +846,17 @@ static void sil24_qc_prep(struct ata_queued_cmd *qc)
>> if (!ata_is_atapi(qc->tf.protocol)) {
>> prb = &cb->ata.prb;
>> sge = cb->ata.sge;
>> + if (ata_is_data(qc->tf.protocol)) {
>> + u16 prot = 0;
>> + ctrl = PRB_CTRL_PROTOCOL;
>> + if (ata_is_ncq(qc->tf.protocol))
>> + prot |= PRB_PROT_NCQ;
>> + if (qc->tf.flags & ATA_TFLAG_WRITE)
>> + prot |= PRB_PROT_WRITE;
>> + else
>> + prot |= PRB_PROT_READ;
>> + prb->prot = cpu_to_le16(prot);
>> + }
>
> I'm trying to remember why we did not do this originally -- Tejun,
> do you recall?
Because that was how the example driver from SIMG worked. :-)
> I do not see any prohibition in the docs, so I am inclined to apply
> this.
Eh... My original thought was to set the protocol only for new cmds
for the sake of least surprise but it does make sense to set the
protocol always. Going through the doc... Yeap, it should just be
fine.
Thanks.
--
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
