On Tue, 23 Jun 2009 02:32:11 -0700 (PDT), David Miller wrote: > From: Jean Delvare <khali@xxxxxxxxxxxx> > Date: Tue, 23 Jun 2009 08:53:24 +0200 > > > I fear somebody else will have to do that. I personally think > > uninitialized_var() should not have been invented, I don't want to have > > my name associated with any of its uses for it will inevitably lead to > > bugs in the future. > > > > I'll resubmit a patch not fixing the warning (because the rest is still > > useful I think) but that's about all I can offer. > > The alternative will be that someone will ask "when does the '0' case > get used" and have to sort through that and potentially ask people > here on the lists. The comment I added, /* Silent compiler warning */, should have answered this question pretty clearly, methinks. > But you posted and update patch which solves the problem in an > even nicer way :-) Is it enough to silent the warning for you? I wasn't for me (gcc 4.3.2), although I expected it to... gcc should be able to see there is no code path leading to the variable being used uninitialized. -- Jean Delvare -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
