From: Jean Delvare <khali@xxxxxxxxxxxx> Date: Mon, 22 Jun 2009 21:10:52 +0200 > PageHighMem() isn't cheap so avoid calling it several times on the > same page. I had the hope that this would silent the following > compilation warning: > > drivers/ide/ide-taskfile.c: In function 'ide_pio_bytes': > drivers/ide/ide-taskfile.c:229: warning: 'flags' may be used uninitialized in this function > > which is a false positive, but it did not. So let's just initialize the > flags and be done with it, so that other developers don't waste their > time looking at it. > > Signed-off-by: Jean Delvare <khali@xxxxxxxxxxxx> > Cc: Bartlomiej Zolnierkiewicz <bzolnier@xxxxxxxxx> Like Borislav, I think it's better to use uninitialized_var(). It describes the situation completely. Please submit an updated patch, and thank you for this. -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
