> Concerning the first point, this module parameter is used in driver > probing function: > ap->pio_mask = pio_mask; > > I would suggest to keep pio_mask as a module parameter, since it might > be useful to modify it in order to сut down PIO speed, e.g. for testing > purposes. Libata already has general support for that. (Arguably we should take it out of the pata_legacy driver in the same way) > > Concerning the second point, I removed set_smc_timing/set_smc_mode from > driver probing function. > > Here is updated patch: Thanks -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html