Re: [PATCH] PATA driver for CF interface on AT91SAM9260 SoC

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> This patch provides PATA driver for CompactFlash interface in True IDE
> mode on AT91SAM9260 SoC.

Couple of points

> +static int pio_mask = ATA_PIO4;
> +module_param(pio_mask, int, 0);

This doesn't appear to be used ? is it a left over that can go

> +	set_smc_timing(dev, info, &initial_timing);
> +	set_smc_mode(info);

The core libata code will call your speed setting methods for PIO_0
before probing the port. I don't think this is needed ?

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Filesystems]     [Linux SCSI]     [Linux RAID]     [Git]     [Kernel Newbies]     [Linux Newbie]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Samba]     [Device Mapper]

  Powered by Linux