On Tuesday 09 June 2009 15:02:20 Hugh Dickins wrote: > On Tue, 9 Jun 2009, Bartlomiej Zolnierkiewicz wrote: > > On Tuesday 09 June 2009 13:44:25 Hugh Dickins wrote: > > > > > > But memset id in probe_for_drive() when it might be being reused - > > > or would it be better to memset it wherever it used to be kfreed? > > > > Please memset() it in ide_port_init_devices_data() -- this function > > is called before IDE device structure is going to be (re-)used. > > That makes sense too, thanks, here we go... > > > [PATCH next] ide: fix PowerMac bootup oops > > PowerMac bootup with CONFIG_IDE=y oopses in ide_pio_cycle_time(): > because "ide: try to use PIO Mode 0 during probe if possible" causes > pmac_ide_set_pio_mode() to be called before drive->id has been set. > > Bart points out other places which now need drive->id set earlier, > so follow his advice to allocate it in ide_port_alloc_devices() > (using kzalloc_node, without error message, as when allocating drive) > and memset it for reuse in ide_port_init_devices_data(). > > Fixed in passing: ide_host_alloc() was missing ide_port_free_devices() > from an error path. > > Signed-off-by: Hugh Dickins <hugh.dickins@xxxxxxxxxxxxx> applied -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
