On Sunday 07 June 2009 21:09:47 Pekka Enberg wrote: > Hi Bartlomiej, > > On Sun, Jun 7, 2009 at 10:00 PM, Bartlomiej Zolnierkiewicz > <bzolnier@xxxxxxxxx> wrote: > >> > My honest opinion is that it is as appropriate now as it will be 2.6.31. > >> > > >> > [ I'm still amazed by the amount of *completely* bogus reasons given for > >> > not merging it. ] > >> > >> I don't consider this a bogus reason at all: > >> > >> 10 files changed, 134 insertions(+), 43 deletions(-) > > > > Since when do we validate code quality based solely on LOC changed? :) > > Since when we entered -rc8 (or even earlier). To be perfectly clear on this: * all patches were posted a week ago to the list (they replaced patches from two weeks ago -- which were intended for -rc8 but thanks to feedback I found a better way to do it). > On Sun, Jun 7, 2009 at 10:00 PM, Bartlomiej Zolnierkiewicz > <bzolnier@xxxxxxxxx> wrote: > > I'm yet to see anybody posting a single code chunk in this whole discussion. > > That's because I am not objecting to the code. I am objecting to the > fact that you're submitting something as big as this so late in the > release cycle and the fact that it's not a clear-cut bug fix. That is a valid objection in contrast to some other ones. Still, changes are really *safe*: * fs/partitions/check.c change is straight-forward (doesn't affect anything besides ide-gd) * ide-gd changes are making it similar in HPA behavior to libata (which is what most distributions are shipping) -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
