On Monday 18 May 2009 15:22:01 Krzysztof Halasa wrote:
> Sergei Shtylyov <sshtylyov@xxxxxxxxxxxxx> writes:
>
> >> } else {
> >> floppy->blocks = blocks;
> >> floppy->block_size = length;
> >> floppy->bs_factor = length / 512;
> >> if (floppy->bs_factor != 1)
> >> - printk(KERN_NOTICE PFX "%s: Warning: "
> >> - "non 512 bytes block size not "
> >> - "fully supported\n",
> >> - drive->name);
> >> + pr_notice(PFX "%s: Warning: non 512 bytes block size not fully supported\n",
> >>
> >
> > Again.
>
> (> 80 chars in line)
>
> Though I think most people would agree that the latter is much better,
> no?
No, it just hides the real issue:
Please factor out descriptor parsing from ide_floppy_get_capacity()
and remove superfluous "Warning: " part of the message instead if you
want something much better.
It is also a real pain for people depending on some kind of automatic
verification of patches (infamous checkpatch.pl ;).
> I think removal (rewording) of this rule has already been agreed upon,
> though not exactly yet codified.
This is not a strict rule but in 99% cases it shows that the code could
be improved further without >80 chars lines.
Thanks.
Bart
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
