On Fri, May 1, 2009 at 3:02 PM, Feng Kan <fkan@xxxxxxxx> wrote:
> This adds the OF platform support for the AMCC 460EX Canyonlands SATA port.
>
> Signed-off-by: Feng Kan <fkan@xxxxxxxx>
> ---
> arch/powerpc/boot/dts/canyonlands.dts | 8 ++
> arch/powerpc/platforms/44x/Makefile | 4 +
> arch/powerpc/platforms/44x/amcc-sata.c | 125 ++++++++++++++++++++++++++++++++
> 3 files changed, 137 insertions(+), 0 deletions(-)
> create mode 100644 arch/powerpc/platforms/44x/amcc-sata.c
>
> diff --git a/arch/powerpc/boot/dts/canyonlands.dts b/arch/powerpc/boot/dts/canyonlands.dts
> index 5fd1ad0..b536223 100644
> --- a/arch/powerpc/boot/dts/canyonlands.dts
> +++ b/arch/powerpc/boot/dts/canyonlands.dts
> @@ -163,6 +163,14 @@
> interrupts = <0x1e 4>;
> };
>
> + SATA0: sata@bffd1000 {
> + compatible = "amcc,sata-460ex";
> + reg = <4 0xbffd1000 0x800 4 0xbffd0800 0x400>;
> + interrupt-parent = <&UIC3>;
> + interrupts = <0 4 /* SATA */
> + 5 4>; /* AHBDMA */
> + };
> +
You should also add documentation for the "amcc,sata-460ex" binding to
Documentation/powerpc/dts-bindings. Doesn't have to be huge, just a
blurb describing the device and what each tuple in the reg &
interrupts properties mean.
g.
--
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
