Re: [PATCH 02/10] ide-tape: don't initialize rq->sector for rw requests

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Tejun Heo <tj@xxxxxxxxxx>
Subject: Re: [PATCH 02/10] ide-tape: don't initialize rq->sector for rw requests
From: Borislav Petkov <petkovbb@xxxxxxxxxxxxxx>
Date: Thu, 30 Apr 2009 08:14:38 +0200
Cc: axboe@xxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, jeff@xxxxxxxxxx, linux-ide@xxxxxxxxxxxxxxx, James.Bottomley@xxxxxxxxxxxxxxxxxxxxx, linux-scsi@xxxxxxxxxxxxxxx, bzolnier@xxxxxxxxx, petkovbb@xxxxxxxxxxxxxx, sshtylyov@xxxxxxxxxxxxx, mike.miller@xxxxxx, chirag.kantharia@xxxxxx, Eric.Moore@xxxxxxx, stern@xxxxxxxxxxxxxxxxxxx, fujita.tomonori@xxxxxxxxxxxxx, zaitcev@xxxxxxxxxx, Geert.Uytterhoeven@xxxxxxxxxxx, sfr@xxxxxxxxxxxxxxxx, grant.likely@xxxxxxxxxxxx, paul.clements@xxxxxxxxxxxx, jesper.juhl@xxxxxxxxx, tim@xxxxxxxxxxxx, jeremy@xxxxxxxxxxxxx, adrian@xxxxxxxxxxxxxxxxx, oakad@xxxxxxxxx, dwmw2@xxxxxxxxxxxxx, schwidefsky@xxxxxxxxxx, ballabio_dario@xxxxxxx, davem@xxxxxxxxxxxxx, rusty@xxxxxxxxxxxxxxx, Markus.Lidel@xxxxxxxxxxxxxxxxx, bharrosh@xxxxxxxxxxx
In-reply-to: <1240996428-10159-3-git-send-email-tj@xxxxxxxxxx>
List-id: <linux-ide.vger.kernel.org>
Mail-followup-to: petkovbb@xxxxxxxxx, Tejun Heo <tj@xxxxxxxxxx>, axboe@xxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, jeff@xxxxxxxxxx, linux-ide@xxxxxxxxxxxxxxx, James.Bottomley@xxxxxxxxxxxxxxxxxxxxx, linux-scsi@xxxxxxxxxxxxxxx, bzolnier@xxxxxxxxx, petkovbb@xxxxxxxxxxxxxx, sshtylyov@xxxxxxxxxxxxx, mike.miller@xxxxxx, chirag.kantharia@xxxxxx, Eric.Moore@xxxxxxx, stern@xxxxxxxxxxxxxxxxxxx, fujita.tomonori@xxxxxxxxxxxxx, zaitcev@xxxxxxxxxx, Geert.Uytterhoeven@xxxxxxxxxxx, sfr@xxxxxxxxxxxxxxxx, grant.likely@xxxxxxxxxxxx, paul.clements@xxxxxxxxxxxx, jesper.juhl@xxxxxxxxx, tim@xxxxxxxxxxxx, jeremy@xxxxxxxxxxxxx, adrian@xxxxxxxxxxxxxxxxx, oakad@xxxxxxxxx, dwmw2@xxxxxxxxxxxxx, schwidefsky@xxxxxxxxxx, ballabio_dario@xxxxxxx, davem@xxxxxxxxxxxxx, rusty@xxxxxxxxxxxxxxx, Markus.Lidel@xxxxxxxxxxxxxxxxx, bharrosh@xxxxxxxxxxx
References: <1240996428-10159-1-git-send-email-tj@xxxxxxxxxx> <1240996428-10159-3-git-send-email-tj@xxxxxxxxxx>
Reply-to: petkovbb@xxxxxxxxx
User-agent: Mutt/1.5.18 (2008-05-17)

On Wed, Apr 29, 2009 at 06:13:40PM +0900, Tejun Heo wrote:
> rq->sector is set to the tape->first_frame but it's never actually
> used and not even in the correct unit (512 byte sectors).  Don't set
> it.
> 
> [ Impact: cleanup ]
> 
> Signed-off-by: Tejun Heo <tj@xxxxxxxxxx>

Acked-by: Borislav Petkov <petkovbb@xxxxxxxxx>

-- 
Regards/Gruss,
    Boris.
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

References:
- [GIT PATCH] block,scsi,ide: unify sector and data_len
  - From: Tejun Heo
- [PATCH 02/10] ide-tape: don't initialize rq->sector for rw requests
  - From: Tejun Heo

Prev by Date: Re: No NCQ support on X61s Ultrabay? (Intel ICH8 SATA controller question)
Next by Date: Re: [PATCH] m68k: Atari - leave out spurious request_irq for Falcon IDE
Previous by thread: [PATCH 02/10] ide-tape: don't initialize rq->sector for rw requests
Next by thread: [PATCH 07/10] block: drop request->hard_* and *nr_sectors
Index(es):
- Date
- Thread

[Index of Archives] [Linux Filesystems] [Linux SCSI] [Linux RAID] [Git] [Kernel Newbies] [Linux Newbie] [Security] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Samba] [Device Mapper]