Dear Feng Kan,
In message <1241042419-19774-1-git-send-email-fkan@xxxxxxxx> you wrote:
> Signed-off-by: Feng Kan <fkan@xxxxxxxx>
> ---
> drivers/ata/Kconfig | 76 +-
> drivers/ata/Makefile | 1 +
> drivers/ata/sata_dwc.c | 2047 ++++++++++++++++++++++++++++++++++++++++++++++++
> 3 files changed, 2091 insertions(+), 33 deletions(-)
> create mode 100644 drivers/ata/sata_dwc.c
>
> diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
> index 0bcf264..5321e47 100644
> --- a/drivers/ata/Kconfig
> +++ b/drivers/ata/Kconfig
> @@ -72,56 +72,66 @@ config SATA_FSL
>
> If unsure, say N.
>
> -config ATA_SFF
> - bool "ATA SFF support"
> - default y
> +config SATA_DWC
> + tristate "DesignWare Cores SATA support"
> + depends on 460EX
> help
> - This option adds support for ATA controllers with SFF
> - compliant or similar programming interface.
> + This option enables support for the Synopsys DesignWare Cores SATA
> + controller.
> + It can be found on the AMCC 460EX.
>
> - SFF is the legacy IDE interface that has been around since
> - the dawn of time. Almost all PATA controllers have an
> - SFF interface. Many SATA controllers have an SFF interface
> - when configured into a legacy compatibility mode.
> + If unsure, say N.
>
> - For users with exclusively modern controllers like AHCI,
> - Silicon Image 3124, or Marvell 6440, you may choose to
> - disable this uneeded SFF support.
> +config ATA_SFF
> +bool "ATA SFF support"
> +default y
> +help
> + This option adds support for ATA controllers with SFF
> + compliant or similar programming interface.
>
> - If unsure, say Y.
> + SFF is the legacy IDE interface that has been around since
> + the dawn of time. Almost all PATA controllers have an
> + SFF interface. Many SATA controllers have an SFF interface
> + when configured into a legacy compatibility mode.
> +
> + For users with exclusively modern controllers like AHCI,
> + Silicon Image 3124, or Marvell 6440, you may choose to
> + disable this uneeded SFF support.
> +
> + If unsure, say Y.
Why are you reformatting exiting, correct help text, into brokenness?
...
> +static irqreturn_t sata_dwc_isr(int irq, void *dev_instance)
> +{
...
> + dev_dbg(ap->dev, "%s non-NCQ cmd interrupt, protocol: %s\n",
> + __func__, prot_2_txt(qc->tf.protocol));
> +DRVSTILLBUSY:
^^^^^^^^^^^^^^^^
...
> +PROCESS: /* process completed commands */
^^^^^^^^^^^
...
> +STILLBUSY:
^^^^^^^^^^^^^
...
> +DONE:
^^^^^^^^
etc. Please do not use all-caps identifier names (not even for
labels).
...
> +/*******************************************************************************
> + * Function : sata_dwc_port_start
> + * arguments : struct ata_ioports *port
> + * Return value : returns 0 if success, error code otherwise
> + * This function allocates the scatter gather LLI table for AHB DMA
> + ******************************************************************************/
Here and elsewhere: incorrect multiline comment style.
...
> +
> +MODULE_LICENSE("GPL");
> +MODULE_AUTHOR("Mark Miesfeld <mmiesfeld@xxxxxxxx>");
Should not Mark add his Signed-off-by: line, too?
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@xxxxxxx
Conscious is when you are aware of something, and conscience is when
you wish you weren't.
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
