Tejun Heo wrote:
Bartlomiej Zolnierkiewicz wrote:
Add local copies of ata_id_string() and ata_id_c_string() to mg_disk
so there is no need for the driver to depend on ATA and SCSI.
Cc: unsik Kim <donari75@xxxxxxxxx>
Cc: Tejun Heo <tj@xxxxxxxxxx>
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@xxxxxxxxx>
Ah.. right, that's a rather large dependency to pull in just for the
string functions. Yeah, I think it would be better to keep local
copy at elast for now.
Acked-by: Tejun Heo <tj@xxxxxxxxxx>
Actually... NVMHCI[1] uses the same style of id string extraction, even
though its command set is wholly new and unrelated to ATA. I copied
into drivers/block/nvmhci.c[2] id_string, id_c_string and another
useful, generic routine: ata_wait_register.
So, once nvmhci goes upstream, that will be a third copy... nvmhci
still has rough edges, but it's mainly waiting on hardware "it works"
verification at this point.
Jeff
[1] http://download.intel.com/standards/nvmhci/spec.pdf
[2] 'nvmhci' branch of
git://git.kernel.org/pub/scm/linux/kernel/git/jgarzik/misc-2.6.git
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
