On Thu, Apr 23, 2009 at 10:39:41AM -0400, Jeff Garzik wrote: > Matthew Wilcox wrote: > >On Thu, Apr 23, 2009 at 02:10:13PM +0000, James Bottomley wrote: > >>I'm with Jeff on this one. We had an identically similar problem with > >>REPORT LUNS, which, today is the basis of SCSI discovery. > > > >Yes, REPORT LUNS is quite essential. > > > >It's not exactly in the same category as reporting device form factor > >and rotational speed. If REPORT LUNS is wrong, we're in really deep > >trouble. If device form factr is wrong ... umm ... nothing much happens. > >If rotational speed is wrong, we might have a suboptimal IO pattern. > > If the general attitude is "oh, that info might be wrong", why will app > developers bother at all? Any info might be wrong. SCSI drives might return the wrong thing in EVPD b1 too. We don't check that in the kernel, we just return it to user space. > >It's also fixable by udev. > > By that logic we should leave it to udev to handle the ata_version <= 7 > stuff, since that is the early adopter special case. I'm perfectly fine with never setting this bit in the kernel and having udev handle all cases, including checking for garbage. -- Matthew Wilcox Intel Open Source Technology Centre "Bill, look, we understand that you're interested in selling us this operating system, but compare it to ours. We can't possibly take such a retrograde step." -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
