Questions: + ATA_FLAG_NO_ATAPI Is this a case of the controller cannot handle ATAPI in which case the flag is correct, or you can't conceive of a user finding a way to add an ATAPI device (but it would work as usually happens with basic PIO hardware) in which case it isn't. + /* we'd better wait for drive's ready signal here + (if we knew where it will come from) */ + msleep(300); Our probe code should already be waiting for ready signals ? The only other question is a general architectural one as to whether it would be better to set up the GPIO etc and create a pata_platform platform device (possibly tweaking pata_platform flags to allow the caller to indicate generic pio with mode setting by set features command) Alan -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
