Hello, Borislav Petkov wrote: >> No, that's checking whether the _previous_ command was REQUEST_SENSE >> which is guaranteed to be set if drive->failed_pc is not NULL. >> drive->pc is set to the current command at the start of >> ide_tape_issue_pc(). > > Damn! Now it all falls into place nicely, thanks for clarifying that. My > original bug analysis was simply plain wrong. > > So, drive->pc means two things: the previous command - until the moment > when it is overwritten with the upcoming command from the current > request _and_ the current command which is being issued. And whether the previous pc is accessible or not depends on which command it actually was and if failed_pc is set, it's guaranteed to be valid. > This is all quite b0rked... Yeah, it's all way too fragile. :-( -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
