RFC Patch: Use x86 init_hwif in the alim15x3 for x86-like PowerPC systems

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

I'm using a Xilinx ML510 it features a PowerPC 440 cpu inside a
Virtex-5 FPGA. The board also contains a ALI M1533 south bridge
for IDE, USB and Audio. I did a lot of work to get the pci bus working
on this board and it works correctly but the default init code
of the alim15x3 driver doesn't work for me. The driver explicitly
disabled some initialization code for powerpc after uncommenting this
code it works properly. Benjamin Herrenschmidt and I think this
!CONFIG_PPC check should be removed because the system behaves
like a real 'x86' system (also the i8259 interrupt controller is used).

Regards,
Roderick Colenbrander


>From 1c40c2f1485ecd3bc5ad7a3af537cb94de0877c3 Mon Sep 17 00:00:00 2001
From: Roderick Colenbrander <thunderbird2k@xxxxxxxxx>
Date: Wed, 15 Apr 2009 10:45:17 +0200
Subject: [PATCH] Use the 'x86' init_hwif code in the alim15x3 for
x86-like PowerPC boards like Xilinx ML310/410/510.

---
 drivers/ide/alim15x3.c |    9 +++++----
 1 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/drivers/ide/alim15x3.c b/drivers/ide/alim15x3.c
index 537da1c..9176c0f 100644
--- a/drivers/ide/alim15x3.c
+++ b/drivers/ide/alim15x3.c
@@ -402,14 +402,15 @@ static u8 ali_cable_detect(ide_hwif_t *hwif)
     return cbl;
 }

-#if !defined(CONFIG_SPARC64) && !defined(CONFIG_PPC)
+#if !defined(CONFIG_SPARC64)
 /**
  *    init_hwif_ali15x3    -    Initialize the ALI IDE x86 stuff
  *    @hwif: interface to configure
  *
  *    Obtain the IRQ tables for an ALi based IDE solution on the PC
- *    class platforms. This part of the code isn't applicable to the
- *    Sparc and PowerPC systems.
+ *    class platforms. This part of the code isn't applicable to
+ *    Sparc systems. It is usable on 'x86-like' PowerPC systems
+ *      which use a Ali M15x3 south bridge like e.g. Xilinx ML310/410/510.
  */

 static void __devinit init_hwif_ali15x3 (ide_hwif_t *hwif)
@@ -455,7 +456,7 @@ static void __devinit init_hwif_ali15x3 (ide_hwif_t *hwif)
 }
 #else
 #define init_hwif_ali15x3 NULL
-#endif /* !defined(CONFIG_SPARC64) && !defined(CONFIG_PPC) */
+#endif /* !defined(CONFIG_SPARC64) */

 /**
  *    init_dma_ali15x3    -    set up DMA on ALi15x3
--
1.5.6.3
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Filesystems]     [Linux SCSI]     [Linux RAID]     [Git]     [Kernel Newbies]     [Linux Newbie]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Samba]     [Device Mapper]

  Powered by Linux