Re: [PATCH] sata_mv: use new sata phy register settings for new devices

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



saeed bishara wrote:
Any chance these magic numbers can be documented?

No objection to this patch and I would prefer a follow on
patch to document the bits if that's possible.
Grant,
    those bits control analog/electrical settings of the sata phy
module, the functional spec uses acronyms to name it, and without much
documentation for it.

Named constants based on acronyms are preferable to numeric constants. A little information and disambiguation is better than none at all.

	Jeff



--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Filesystems]     [Linux SCSI]     [Linux RAID]     [Git]     [Kernel Newbies]     [Linux Newbie]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Samba]     [Device Mapper]

  Powered by Linux