> Any chance these magic numbers can be documented? > > No objection to this patch and I would prefer a follow on > patch to document the bits if that's possible. Grant, those bits control analog/electrical settings of the sata phy module, the functional spec uses acronyms to name it, and without much documentation for it. saeed -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html