On Fri, Apr 3, 2009 at 12:41 PM, Bartlomiej Zolnierkiewicz <bzolnier@xxxxxxxxx> wrote: > On Friday 03 April 2009, Borislav Petkov wrote: >> Hi, >> >> On Fri, Apr 03, 2009 at 01:08:39AM +0200, Bartlomiej Zolnierkiewicz wrote: >> > On Thursday 02 April 2009, Borislav Petkov wrote: >> > > - have (almost) equal handling of commands based solely on sense_key >> > >> > I'm having a VERY hard time trying to review this patch because at >> > the same time that codepaths were merged if()s were replaced by switch() >> > which in turn resulted in change of intendation... on top of that >> > the patch description is very vague about this part of the changes... >> >> I completely and exactly understand what you are saying :), I thought so >> too when I looked at the diffs yesterday. Well, if it's any consolation, the >> patches've been tested so they seem to work :). Anyway, split version coming >> up... > > The split version looks exactly the same except ide_cd_breathe() change > when it comes to the main part. > > Did you send the wrong version by any chance? No, but I can't split those changes anymore logically. The switch-case handles the differentiation based on the sense_key and as such cannot be broken down anymore without doing some weird stuff and possibly introducing more bugs and breaking bisectability. Completely hypothetically: wouldn't a before-after juxtaposition of the change make reviewing more easier, for example you apply the patch on a different branch and compare the before and the after version? -- Regards/Gruss, Boris -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
