bug in use-ide_pio_bytes patch?

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello, Bartlomiej.

I've been looking at the pata-2.6 patches and use-ide_pio_bytes patch
contains the following snippet.

  void ide_init_pc(struct ide_atapi_pc *pc)
  {
	 memset(pc, 0, sizeof(*pc));
 @@ -351,6 +308,9 @@ static ide_startstop_t ide_pc_intr(ide_d
			 pc->xferred = pc->req_xfer;
			 if (drive->pc_update_buffers)
				 drive->pc_update_buffers(drive, pc);
 +
 +			if (drive->media == ide_floppy)
 +				ide_complete_rq(drive, 0, blk_rq_bytes(rq));
		 }
		 debug_log("%s: DMA finished\n", drive->name);
	 }

It completes ide_floppy requests in the DMA handling block; however,
those requests are gonna be completed again later in the regular
completion path again.  I think the above part can be simply dropped?

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Filesystems]     [Linux SCSI]     [Linux RAID]     [Git]     [Kernel Newbies]     [Linux Newbie]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Samba]     [Device Mapper]

  Powered by Linux