Tejun Heo wrote: > Hello, Mark. > > Mark Lord wrote: >> + if (cnt && cnt <= max && (max & (max - 1)) == 0) { > > Can you please include <linux/log2.h> and use is_power_of_2() instead? Please note that is_power_of_2() also checks for zero so the whole condition can be changed to if (is_power_of_2(cnt) && cnt <= max) Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html