Hello, Mark. Mark Lord wrote: > A suggestion, then. As a follow-up patch, would it be possible > to drop the workaround kludge, and restore the missing SCR access, > __after the first time that a drive is detected on that port__? Hmmm... yeah. Maybe but it would either involve changing ap->ops on the fly (which is a big no no) or wrap SCR access such that it returns -EOPNOTSUPP if the kludge is in effect. > This way, there won't be any funny business for cases where > the same ID might occur on different (non-botched) hardware ? > > Probably overkill, though. :) Missing SCR access doesn't impact direct usage too much, so yeah I think it should be fine as it is until there's some evidence that the subsystem IDs are in far wider use. Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
