Tuesday 03 February 2009 21:27:04 Andrew Victor napisał(a):
> hi Stanislaw,
Hi.
> > +void __init at91_add_device_ide(struct at91_ide_data *data)
> > +{
>
> This platform initialization code is virtually identical to the
> at91_cf version submitted by Uros Bizjak, albeit for the SAM9260.
> Similarly the "at91_cf_data" and "at91_ide_data" structs.
>
> Wouldn't it be better to have a single CF initialization function, and
> you specify whether you want "plain CF" mode or True-IDE mode?
> You could even pass the same platform-resources structure (ie,
> base-address of CF region), and have at91_ide setup the location of
> the task-file and control registers from that base address.
Yes, this can be merged together. Ronetix already did a SAM9263 board
and linux patch with "full" CF device.
http://download.ronetix.info/sk-eb926x/linux/kernel/2.6.28/003_linux-2.6.28-at91-ronetix-12012009.patch
There are some difference, but I think CF stuff can have one initialization
function. Could this be a separate patch in later date? I would like marge
at91_ide into mainline without changes if there will be no objections.
Cheers
Stanislaw Gruszka
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
