hi Stanislaw, > +void __init at91_add_device_ide(struct at91_ide_data *data) > +{ This platform initialization code is virtually identical to the at91_cf version submitted by Uros Bizjak, albeit for the SAM9260. Similarly the "at91_cf_data" and "at91_ide_data" structs. Wouldn't it be better to have a single CF initialization function, and you specify whether you want "plain CF" mode or True-IDE mode? You could even pass the same platform-resources structure (ie, base-address of CF region), and have at91_ide setup the location of the task-file and control registers from that base address. Regards, Andrew Victor -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html