Re: [PATCH] ide/libata: fix ata_id_is_cfa()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Alan Cox wrote:

I'm sorry, that was totally off base. I've misread this whole paragraph in haste. :-<
   The rest of my evening was wasted, sigh.

If it got the CF code fixed it wasn't a waste.

Do I understand rightly that the agreed things to do are

- redo the version check patch using the signed check as you suggested
and remove the changes to the CFA check from it

   Yes, those shouldn't have been intermixed from the very start.

- make the CFA code check word 80 == 0 as a sanity check

That'll work unless we bump into a drive that does follow ATA in that matter. My vote would still be for ignoring the version...

- apply your change to check the bit in the right command word for CFA

My change wasn't only that. I will repost it after some sleep -- with word 80 check for 0 if you're so adamant about it.

Alan

MBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Filesystems]     [Linux SCSI]     [Linux RAID]     [Git]     [Kernel Newbies]     [Linux Newbie]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Samba]     [Device Mapper]

  Powered by Linux