Re: [PATCH] ide/libata: fix ata_id_is_cfa()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Alan Cox wrote:

totally wrong in that part from the very start -- CF devices don't report ATA standard support in word 80, that's forbidden (!) by the CF specs since at least 2.1.

And the ATA world says that if word 80 doesn't report any standards then
the word is potentially undefined....

   It's all your fantasy this time. :-D
Do start reading the specs attentively. All ATA standards only have that if bits 14:15 are not 1:0, the words are not valid (as a variant, if the word is 0 or 0xFFFF).

> welcome to PC hell

I've started on PCs, and spent "the best years of my life" with them -- no need to welcome me. :-)

Perhaps the best we can do is to test

	word 80 == 0 && word 83 bit set && word 83 valid

Fortunately the use is almost entirely to print the right CFA/ATA string
at boot ?

   What about PIO/DMA modes?

Now Sergei if you'd said that explicitly (or if you did before I didn't
see it) it would have been a bit simpler to work out why you were arguing
the needed for these changes.

If you think that I now have plenty of time to look into all the CF and ATA standard, you are very wrong. However, you caused me to lose much time on that pointless argument...

Alan

MBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Filesystems]     [Linux SCSI]     [Linux RAID]     [Git]     [Kernel Newbies]     [Linux Newbie]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Samba]     [Device Mapper]

  Powered by Linux